This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add timeout for attr for dockerfile_image.
#2230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesoconor
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
Some build take longer than 10 minutes since this doesn't use the docker cache so larger images can be slow.
charlesoconor
force-pushed
the
add-timeout-option-for-docker-file
branch
from
46c9271
to
7653ba3
Compare
|
Any idea when people might look at this? can close if it doesn't make sense, but I would like to know why. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build take longer than 10 minutes since this doesn't use the docker cache so larger images can be slow.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the
dockerfile_imagewill timeout after 10 minutes. Since there isn't a cache larger images builds can take longer than that especially on slow networks.Issue Number: N/A
What is the new behavior?
This adds the option to set a higher timeout for the action.
Does this PR introduce a breaking change?
dockerfile_build